Stm32l47x adc temperature #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you feel like fixing this PR now that the feature gates available? :) |
|
Will get it done before this weekend |
Crzyrndm
force-pushed
the
stm32l47x-adc-temperature
branch
from
aa3e7d1 to
2d3884a
Compare
Rename the calibration structs to Low/High instead of 30/130 for clarity * 130 makes no sense when L47 uses 110 and Call30 and Cal30 can also be easily mistaken at a glance High constant is conditional on the device product feature
Crzyrndm
force-pushed
the
stm32l47x-adc-temperature
branch
from
2d3884a to
58c0e8c
Compare
|
Thanks for fixing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #257