Add support for GD32VF103 chips [rebase] [rebase] #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of the rebase #36 of the original #25.
I tested it with the serial example from Disasm/usb-otg-workspace#7 (also had to rebase that, available upon request).
I realize testing is the problem with merging this. Sadly, I don't have that many devices, so I couldn't test across the entire range.
I think this feature is really useful, and seeing that this is the third time it's been proposed, I'm not the only one. I am willing to put in extra effort to have it merged in some form, rather than wait another 2 years waiting for testing that the community is unable to provide.
So if this cannot be merged the way it is now, I propose a solution:
I create a feature "gd32v103", which contains these changes. It is not enabled by default, so existing device support is unaffected. People who want to use this crate on GD32 microcontrollers must enable the feature. People who want to test the new code on STM32 controllers can enable this feature. Once all devices have been tested, the old code is removed and the feature is removed, too.
Would this solution make it mergeable?