Skip to content

update aws sdk version #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

update aws sdk version #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26ebd6f
update aws sdk version
summeroff Feb 5, 2025
6f9cb4e
workaround for win ssl bug
summeroff Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
RELEASE_BUCKET: "slobs-crash-handler"
ELECTRON_VERSION: "v29.4.3"
BIN_DEPENDENCIES: "dependencies2019.0"
AWS_SDK_VERSION: "1.11.367"
AWS_SDK_VERSION: "1.11.500"
AWS_SDK_PATH: "aws-sdk/awsi"

permissions:
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ yarn install
set BIN_DEPENDENCIES=dependencies2019.0
ci\install-bin-deps.cmd

set AWS_SDK_VERSION="1.11.367"
set AWS_SDK_VERSION="1.11.500"
ci\build-aws-sdk.cmd

ci\localization_prepare_binaries.cmd

set AWS_CRASH_UPLOAD_BUCKET_KEY=your_aws_bucket_key_for_memory_dumps
set INSTALL_PACKAGE_PATH="../desktop/node_modules/crash-handler"

cmake -B"build" -G"Visual Studio 17 2022" -A x64 -DDepsPath="%CD%\build\deps\%BIN_DEPENDENCIES%\win64" -DBOOST_ROOT="%CD%\build\deps\boost" -DCMAKE_INSTALL_PREFIX="%INSTALL_PACKAGE_PATH%"
cmake --build "build" --target install --config RelWithDebInfo
```
Expand Down
2 changes: 1 addition & 1 deletion crash-handler-process/platforms/util-win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ bool Util::uploadToAWS(const std::wstring &wspath, const std::wstring &fileName)
config.region = region;
}
config.scheme = Aws::Http::Scheme::HTTPS;
config.verifySSL = false;
config.verifySSL = true;
config.followRedirects = Aws::Client::FollowRedirectsPolicy::NEVER;
Aws::Auth::AWSCredentials aws_credentials;
aws_credentials.SetAWSAccessKeyId(accessIDKey);
Expand Down
Loading