Migrate video settings to realm and remove video settings service. #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (3)
Total files change -2.37KB -0.02% Final result: ✅ View report in BundleMon website ➡️ |
gettinToasty
approved these changes
Apr 10, 2025
| @@ -23,6 +24,9 @@ export default function DisplaySelector(p: IDisplaySelectorProps) { | |||
| } = useGoLiveSettings(); | |||
|
|
|||
| const setting = p.platform ? platforms[p.platform] : customDestinations[p.index]; | |||
| const label = p.platform | |||
| ? platformLabels(p.platform) | |||
| : (setting as ICustomStreamDestination).name; | |||
There was a problem hiding this comment.
it looks like we aren't referencing p.label anymore? should we just get rid of that prop?
|
|
||
| const videoSettings = useRealmObject(Services.VideoService.state); | ||
| const dualOutputMode = DualOutputService.views.dualOutputMode; | ||
| const cantEditFields = StreamingService.views.isStreaming || StreamingService.views.isRecording; |
There was a problem hiding this comment.
i dont think these are reactive but also i dont think they'd change while this window is open so its probably ok
| await this.gameOverlayService.destroy(); | ||
| this.videoService.shutdown(); |
There was a problem hiding this comment.
curious about this change but not a blocker
| this.videoService.setBaseResolution(this.data.baseResolutions); | ||
| this.streamingService.setSelectiveRecording(!!this.data.selectiveRecording); | ||
| this.streamingService.setDualOutputMode(this.data.dualOutputMode); | ||
| this.videoService.setBaseResolution(this.data.baseResolutions); |
There was a problem hiding this comment.
love to see the simplification here :D
|
|
||
| return videoSettings; | ||
| } catch (e: unknown) { | ||
| console.warn('Error fetching video settings from video factory', e); |
There was a problem hiding this comment.
not a big deal but i think this error was copypasted from the above one
| // const base = `${settings.baseWidth}x${settings.baseHeight}`; | ||
| // const output = `${settings.outputWidth}x${settings.outputHeight}`; | ||
| // } | ||
| } |
There was a problem hiding this comment.
looks like this function is no longer used?
| // const output = `${this.state.horizontal.video.outputWidth}x${this.state.horizontal.video.outputHeight}`; | ||
| // this.settingsService.setSettingValue('Video', 'Output', output); | ||
| // } | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.