Skip to content

🐛(frontend) fix multiple EmojiPicker #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

🐛(frontend) fix multiple EmojiPicker #1012

merged 2 commits into from
Jun 11, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented May 26, 2025

Purpose

emoji-mart is used to display emojis in the editor.
It is used by the callout block and by Blocknotes editor.
The problem is that the emoji-mart is a singleton, so if Blocknotes components init the emoji-mart first, the picker in the callout block will not display correctly.
This commit fixes the issue by initializing the emoji-mart in the callout block first.

Proposal

  • 🐛(frontend) fix multiple EmojiPicker
  • 💄(frontend) adapt padding on editor paragraph

@AntoLC AntoLC self-assigned this May 26, 2025
@AntoLC AntoLC added bug Something isn't working frontend editor labels May 26, 2025
@AntoLC AntoLC force-pushed the fix/multiple-emojy branch from cf8264e to 95e2ff7 Compare May 26, 2025 13:49
@AntoLC AntoLC force-pushed the fix/multiple-emojy branch from 95e2ff7 to c9ed172 Compare May 27, 2025 08:37
AntoLC added 2 commits June 11, 2025 10:03
emoji-mart is used to display emojis in the editor.
It is used by the callout block and by
Blocknotes editor. The problem is that the emoji-mart
is a singleton, so if Blocknotes components init
the emoji-mart first, the picker in the callout block
will not display correctly.
This commit fixes the issue by initializing
the emoji-mart in the callout block first.
- editor block padding only when background
- increase icon shadow grid
@AntoLC AntoLC force-pushed the fix/multiple-emojy branch from c9ed172 to c5f018e Compare June 11, 2025 08:03
@AntoLC AntoLC merged commit c5f018e into main Jun 11, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the fix/multiple-emojy branch June 11, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working editor frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants