Feature/custom translations frontend #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
10cd759 to
d285bd1
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
4ff16fa to
81fd1ed
Compare
AntoLC
reviewed
Apr 9, 2025
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
b9b16aa to
06b91a1
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
06b91a1 to
af92119
Compare
AntoLC
reviewed
Apr 22, 2025
src/frontend/apps/impress/src/features/language/hooks/useTranslationsCustomizer.ts
Outdated
Show resolved
Hide resolved
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
a65fca6 to
cddc429
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
cddc429 to
9a9b717
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
3 times, most recently
from
5f855f1 to
ed137ef
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
ed137ef to
2e7f552
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
2e7f552 to
6a036b3
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
6a036b3 to
6a75453
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
0080fdc to
bf65c8b
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
3 times, most recently
from
d86f811 to
f7abb03
Compare
AntoLC
reviewed
May 16, 2025
src/frontend/apps/impress/src/features/language/hooks/useCustomTranslations.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useCustomTranslations.ts
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/language/hooks/useCustomTranslations.ts
Outdated
Show resolved
Hide resolved
|
|
||
| const availableFrontendLanguages = useMemo( | ||
| () => Object.keys(i18n?.options?.resources || { en: '<- fallback' }), | ||
| [i18n], |
There was a problem hiding this comment.
Suggested change
| [i18n], | |
| [i18n?.options?.resources], |
src/frontend/apps/impress/src/features/language/hooks/useSynchronizedLanguage.ts
Outdated
Show resolved
Hide resolved
Comment on lines
65
to
70
| log('Updating frontend language (%O)', { | ||
| requested: language, | ||
| from: i18n.resolvedLanguage, | ||
| to: closestFrontendLanguage, | ||
| }); | ||
| void i18n.changeLanguage(closestFrontendLanguage); |
There was a problem hiding this comment.
Same it is part of the development part, should be removed.
src/frontend/apps/impress/src/features/auth/api/useAuthMutation.ts
Outdated
Show resolved
Hide resolved
| currentBackendLanguage, | ||
| currentFrontendLanguage, | ||
| changeLanguageSynchronized, | ||
| currentUser, |
There was a problem hiding this comment.
Is currentUser necessary ?
| [changeBackendLanguage, changeFrontendLanguage, currentUser], | ||
| ); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I have the feeling this useEffect is trigger often.
There was a problem hiding this comment.
It was not good to have the useEffect in the useSynchronizedLanguage hook anyways,
as it added 1 useEffect call, everytime useSynchronizedLanguage() is instantiated.
To counteract, one would need to develop a Provider to share Context.
Since i didn't see the need for a dedicated Provider just to prevent a race condition / enable singleton pattern, i instead moved the useEffect to the ConfigProvider and simplified useSynchronizedLanguage to only be responsible for change language.
The default behavior ("sync frontend detected language to backend if backend language is null") is now handeled in the ConfigProvider. It looks more on par with what we already have in there.
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
f7abb03 to
4d59da8
Compare
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
3 times, most recently
from
372b8d9 to
bb1c96e
Compare
AntoLC
approved these changes
May 30, 2025
src/frontend/apps/impress/src/features/header/components/Header.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/home/components/HomeHeader.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanel.tsx
Outdated
Show resolved
Hide resolved
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
2 times, most recently
from
b7ed541 to
5ad421c
Compare
Part of customization PoC Signed-off-by: Robin Weber <[email protected]>
Part of customization PoC Signed-off-by: Robin Weber <[email protected]>
Introduces dedicated mutations (for authentication/user operations) separating them from queries to align with best practices for data fetching and state management. Queries remain responsible for READ operations, while mutations now handle CREATE, UPDATE, and DELETE actions (for user data) improving separation of concerns. Signed-off-by: Robin Weber <[email protected]>
- Refactors "useTranslationsCustomizer" to "useCustomTranslations" - Refactors "useLanguageSynchronizer" to "useSynchronizedLanguage" - Refactors "LanguagePicker" to better reflect its component role - Refactors "LanguagePicker" to use "useSynchronizedLangue" - Removes unused "useChangeUserLanguage" - To change the user language, use "useAuthMutation" instead Signed-off-by: Robin Weber <[email protected]>
- Language will only be changed if different from current language - Added test for custom translations Signed-off-by: Robin Weber <[email protected]>
rvveber
force-pushed
the
feature/custom-translations-frontend
branch
from
5ad421c to
94e9978
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibilty to inject/override custom translations at runtime.