Change main from extern "C" to "Rust", and rename to origin_main
#39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/extern-rust-take2
branch
from
40a4b23 to
3daa7dc
Compare
This function is called from Rust code, so it doesn't need to be `extern "C"`.
This isn't the C ABI `main` function, so give it a different name. Also, make it an `unsafe fn`, and add the `envp` arguments so that we don't rely on the ABI to ignore extra arguments.
This memory is mutable, and users may want to mutate it, so use `*mut`.
Change `argc` to `usize` because a common use case is to pass it to `slice::from_raw_parts`. Change the return value to `i32`. This matches the type used by `std::process::exit`.
sunfishcode
force-pushed
the
sunfishcode/extern-rust-take2
branch
from
3daa7dc to
16bcfaf
Compare
|
This isn't the last word on this toppic, but this PR is an improvement over the previous code, so I'm going to merge it for now, and we can continue to discuss alternative approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin's
mainfunction isn't called from FFI, so useextern "Rust"instead ofextern "C", and rename it toorigin_mainto avoid confusion and collision with othermainfunctions.Also, use
*mutfor the pointers, since the memory is mutable and users may want to mutate it, and useusizeforargcto avoid exposingc_intin the public API.This includes the patch from #34.