fix: tenant s3 credentials fixes and refactor #668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14712560337Details
💛 - Coveralls |
itslenny
force-pushed
the
fix/s3-credential-cache-notify-fix
branch
from
35e8d8e to
c6f2e5e
Compare
fenos
approved these changes
Apr 22, 2025
fenos
reviewed
Apr 22, 2025
| @@ -0,0 +1,126 @@ | |||
| import crypto from 'node:crypto' | |||
There was a problem hiding this comment.
Can we move this to storage/protocols/s3/credentials-manager.ts
- migration to use correct cache key in pg_notify cache invalidation - fix s3 credentials count, was always returning 0 (and allowing creation of > 50 credentials) - check for valid uuid on delete credential endpoint (used to throw 500 on insert) - add test coverage - refactor s3 credentials into manager pattern similar to jwks
itslenny
force-pushed
the
fix/s3-credential-cache-notify-fix
branch
from
c6f2e5e to
3f9cc09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Cache does not invalidate on database update/delete and s3 credential count always returns 0
What is the new behavior?
Cache is invalidated on database update/delete, credential count returns correct value, credentials limited to 50, cleaner architecture, improved test coverage
Changes