Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: test ordering of concurrent query in async mode #166

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Anton-2
Copy link
Contributor

@Anton-2 Anton-2 commented Feb 26, 2025

What is the motivation?

Following #164 and discussion with @maxwellflitton , extend async tests to catch concurrent response ordering error

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

What does this change do?

Add a test showing that current lock mechanism fails with concurrent queries taking different time to finish.

What is your testing strategy?

It's a test ;-)

Is this related to any issues?

#164 and async mode of this library in general

Have you read the Contributing Guidelines?

@maxwellflitton maxwellflitton merged commit 6ede6ba into surrealdb:async-batching Feb 27, 2025
0 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants