fixing duration class and adding a testing file for it #175
+129
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
nicolube
suggested changes
Apr 9, 2025
| @@ -65,7 +62,7 @@ def default_encoder(encoder, obj): | |||
| tagged = CBORTag(constants.TAG_BOUND_EXCLUDED, obj.value) | |||
|
|
|||
| elif isinstance(obj, Duration): | |||
| tagged = CBORTag(constants.TAG_DURATION, obj.get_seconds_and_nano()) | |||
| tagged = CBORTag(constants.TAG_DURATION, obj.to_string()) | |||
There was a problem hiding this comment.
Should this not be constants.TAG_DURATION_COMPACT since obj.get_seconds_and_nano() returns the correct format for that?
| @@ -116,6 +113,8 @@ def tag_decoder(decoder, tag, shareable_index=None): | |||
| return Range(tag.value[0], tag.value[1]) | |||
|
|
|||
| elif tag.tag == constants.TAG_DURATION_COMPACT: | |||
| if len(tag.value) == 1: | |||
There was a problem hiding this comment.
This should be the decoding for constants.TAG_DURATION see:
https://surrealdb.com/docs/surrealdb/integration/cbor#tag-14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
offering a fix to the
Durationfield not working withcboras highlighted in this issueType of Change
What does this change do?
Gets Duration working with
CborWhat is your testing strategy?
I've written a testing file to test how the
Durationdata type processes data and how it interacts with the SurrealDB database.Is this related to any issues?
issue
Have you read the Contributing Guidelines?