Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hover Focus Dimming Feature for Designer View #758

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cabaucom376
Copy link
Contributor

@cabaucom376 cabaucom376 commented Apr 5, 2025

Summary

Implements a visual feature that dims unrelated nodes and edges when hovering over tables in the Designer Table Graph, improving clarity of complex diagrams. Maybe closes #613.

Changes

  • Added support for "dim" option in DiagramHoverFocus preference
  • Implemented hover state tracking and class-based dimming (0.3 opacity)
  • Added special handling for drag operations (temporarily disables dimming)
  • Updated CSS to apply dimming to nodes, edges, and text labels

Testing

  • Set Designer Hover Focus to "dim" in settings
  • Hover over any table to see dimming effect
  • Verify connected tables remain visible while others dim
  • Confirm dimming is suspended during drag operations

@cabaucom376 cabaucom376 requested a review from macjuul as a code owner April 5, 2025 01:40
When a label overlapped a link, its background would break a highlighted link when the label was dimmed out.
@cabaucom376
Copy link
Contributor Author

@macjuul, I’d like to get your thoughts on this. I just added a feature for recursively dimming relations. However, there are two different approaches to handling this.

  1. Deeply recurse all nodes and display the entire relation tree.
  2. Only recurse forward or backward in a more linear chain-like manner. (This is the approach I’ve chosen for now.)

I recognize the utility in both methods and may want to include an option for each. However, I’m not sure what naming conventions would be most intuitive for users. Additionally, I’m wondering if this is becoming too bloated or if it’s simply a naming convention issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add coloring of lines (in/out) in the Designer view
1 participant