Skip to content

chore: avoid loading page nodes three times #13540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

chore: avoid loading page nodes three times #13540

merged 1 commit into from
Mar 4, 2025

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Mar 4, 2025 •
edited
Loading

Loading page nodes a single place will make it easier to check if SSR is enabled without loading the module for #12580. It's probably also a bit better for performance

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2a3a31f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-kit-13540-svelte.vercel.app/

@benmccann benmccann force-pushed the load_page_nodes branch 2 times, most recently from 14930c8 to 2a3a31f Compare March 4, 2025 17:42
@benmccann benmccann merged commit 0f82298 into main Mar 4, 2025
28 of 29 checks passed
@benmccann benmccann deleted the load_page_nodes branch March 4, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benmccann @elliott-with-the-longest-name-on-github