Skip to content

chore: centralize page node logic into a class #13550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2025
Merged

chore: centralize page node logic into a class #13550

merged 7 commits into from
Mar 6, 2025

Conversation

benmccann
Copy link
Member

Working some more towards #12580. It's proving really tricky to do. This will hopefully make it a bit easier by putting more of the code that needs to be updated into a single file vs having it spread across a few different ones

Copy link

changeset-bot bot commented Mar 5, 2025

⚠️ No Changeset found

Latest commit: b6fdfe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense regardless of the referenced issue - nice refactoring!

@dummdidumm dummdidumm merged commit 729aa7d into main Mar 6, 2025
15 checks passed
@dummdidumm dummdidumm deleted the page_nodes branch March 6, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants