Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write server files to _worker.js/ directory #13610

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

eltigerchino
Copy link
Member

fixes #13300

This PR changes the written _worker.js file to a directory, allowing us to include the server files in the .svelte-kit/cloudflare build output without making them public. It was not possible to include the server files before because all the files in the build output are made public, but there is an undocumented feature in Wrangler that allows us to store all server files in a _worker.js/ directory to be bundled. The result is that all build artefacts are once again stored in a single directory instead of linking server files relatively to the Vite output folder.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 19, 2025

🦋 Changeset detected

Latest commit: 57abafb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eltigerchino eltigerchino changed the title write server to _worker.js directory fix: write server files to _worker.js/ directory Mar 19, 2025
@eltigerchino eltigerchino merged commit 6e85831 into main Mar 20, 2025
18 checks passed
@eltigerchino eltigerchino deleted the fix-cf-pages-build-artifact branch March 20, 2025 01:33
@github-actions github-actions bot mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[email protected] breaks deployment
2 participants