Skip to content

stream request bodies #5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/afraid-flowers-train.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Stream request bodies
57 changes: 24 additions & 33 deletions packages/kit/src/node/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,51 +2,42 @@ import * as set_cookie_parser from 'set-cookie-parser';

/** @param {import('http').IncomingMessage} req */
function get_raw_body(req) {
return new Promise((fulfil, reject) => {
const h = req.headers;
const h = req.headers;

if (!h['content-type']) {
return fulfil(null);
}
if (!h['content-type']) {
return null;
}

req.on('error', reject);
const length = Number(h['content-length']);

const length = Number(h['content-length']);
// check if no request body
// https://github.com/jshttp/type-is/blob/c1f4388c71c8a01f79934e68f630ca4a15fffcd6/index.js#L81-L95
if (isNaN(length) && h['transfer-encoding'] == null) {
return null;
}

// https://github.com/jshttp/type-is/blob/c1f4388c71c8a01f79934e68f630ca4a15fffcd6/index.js#L81-L95
if (isNaN(length) && h['transfer-encoding'] == null) {
return fulfil(null);
}
return new ReadableStream({
start(controller) {
req.on('error', (error) => {
controller.error(error);
});

let data = new Uint8Array(length || 0);
let size = 0;

if (length > 0) {
let offset = 0;
req.on('data', (chunk) => {
const new_len = offset + Buffer.byteLength(chunk);
size += chunk.length;

if (new_len > length) {
return reject({
status: 413,
reason: 'Exceeded "Content-Length" limit'
});
if (size > length) {
controller.error(new Error('content-length exceeded'));
}

data.set(chunk, offset);
offset = new_len;
controller.enqueue(chunk);
});
} else {
req.on('data', (chunk) => {
const new_data = new Uint8Array(data.length + chunk.length);
new_data.set(data, 0);
new_data.set(chunk, data.length);
data = new_data;

req.on('end', () => {
controller.close();
});
}

req.on('end', () => {
fulfil(data);
});
});
}

Expand All @@ -67,7 +58,7 @@ export async function getRequest(base, req) {
return new Request(base + req.url, {
method: req.method,
headers,
body: await get_raw_body(req) // TODO stream rather than buffer
body: get_raw_body(req)
});
}

Expand Down