SwiftDriverTests: adjust module count on Windows #1151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent refactoring for Windows increased the module count for the system modules and this resulted in the test suite failing due to the difference. This is technically backwards incompatible and expects that the most recent toolchain is in use but it seems unclear how to account for that easily.
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
|
Please test with following PRs: @swift-ci please test Windows platform |
DougGregor
approved these changes
Aug 10, 2022
|
We could make this a looser check (between 10 and 15 or whatever), but this fix to unblock the refactoring LGTM. |
|
Yeah, I suppose that we could create the window, but I like the specificity - it ensures that we do not accidentally slip in modules (or drop modules). Stronger guarantees vs easier maintenance tradeoffs 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent refactoring for Windows increased the module count for the
system modules and this resulted in the test suite failing due to the
difference. This is technically backwards incompatible and expects that
the most recent toolchain is in use but it seems unclear how to account
for that easily.