[6.2] Check version has been updated when publishing a release #1029
Conversation
Rather than updating the version, check that it has been. We need the update in the branch itself so that the toolchain version is also updated.
| print("main") | ||
| print("6.2.0") |
There was a problem hiding this comment.
Wouldn't it be more appropriate if it were in the form of "602.0.0"?
There was a problem hiding this comment.
Heh, this is an interesting point. We really have two versions here - one is swift-format as a library, using the same semantic versioning as swift-syntax. Another is swift-format in the toolchain, which uses the toolchain versioning scheme.
Which also means the check I added here doesn't work 🤔
| @@ -67,6 +67,9 @@ jobs: | |||
| echo "swift_format_version=$SWIFT_FORMAT_VERSION" >> "$GITHUB_OUTPUT" | |||
| - name: Checkout repository | |||
| uses: actions/checkout@v4 | |||
| - name: Check version matches | |||
| run: | | |||
| grep '"${{ steps.swift_format_version.outputs.swift_format_version }}"' Sources/swift-format/PrintVersion.swift | |||
There was a problem hiding this comment.
I think we should also take into account the prerelease format, such as "602.0.0-prerelease-$(date +'%Y-%m-%d')" 🤔
Or, to avoid being affected by prerelease variations, it might be better to use github.event.inputs.swift_format_version instead of steps.swift_format_version.outputs.swift_format_version.
Rather than updating the version, check that it has been. We need the
update in the branch itself so that the toolchain version is also
updated.
Also update the version itself (currently main).