[6.2][Data] Fix build issue with Static SDK for Linux. #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
al45tair
changed the title
|
@swift-ci Please test |
|
This is a cherry pick of #1293 |
al45tair
force-pushed
the
fix-static-sdk-build-6.2
branch
from
6c54e5b to
f275b2c
Compare
|
@swift-ci Please test |
|
Explanation: Fixes a build issue when building Foundation for the Static SDK for Linux. |
|
I'm still hoping to get a merger from main to 6.2. |
Musl's definition of `S_IFMT` gets imported by the Swift importer, which means Swift can see `S_IFMT` as a `CInt` and also `S_IFMT` from the Swift overlay as a `mode_t`. The upshot is that attempting to convert it to `mode_t` produces an ambiguity error, as Swift doesn't know which definition to use. rdar://147201087
al45tair
force-pushed
the
fix-static-sdk-build-6.2
branch
from
f275b2c to
1b4c1d3
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Musl's definition of
S_IFMTgets imported by the Swift importer, which means Swift can seeS_IFMTas aCIntand alsoS_IFMTfrom the Swift overlay as amode_t. The upshot is that attempting to convert it tomode_tproduces an ambiguity error, as Swift doesn't know which definition to use.