-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Tests: Augment SwiftBuild build provider test coverage #8555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bkhouri
wants to merge
3
commits into
swiftlang:main
Choose a base branch
from
bkhouri:t/main/more_swiftbuild_test_coverage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Tests: Augment SwiftBuild build provider test coverage #8555
bkhouri
wants to merge
3
commits into
swiftlang:main
from
bkhouri:t/main/more_swiftbuild_test_coverage
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
cmcgee1024
reviewed
Apr 24, 2025
cmcgee1024
reviewed
Apr 24, 2025
aa454fb
to
904b4ac
Compare
@swift-ci test |
bkhouri
commented
Apr 24, 2025
@swift-ci test |
Augment some test to run against the native and swiftbuild build providers to gain extra confidence with the swift build integration. Update Test helpers to use BuildConfiguration in production code instead of configuration Where applicable, create a test swift for the various build configurations to allow to better skip test in specific scenarios.
db11d96
to
e9f4fa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be updated before marking as ready.