Rename Build module to NativeBuildSupport #8571
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
bnbarham,
MaxDesiatov,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
MaxDesiatov
approved these changes
Apr 29, 2025
jakepetroules
force-pushed
the
eng/PR-rename-build-module
branch
from
91c6dc1 to
6b2856a
Compare
|
@swift-ci test |
|
@swift-ci test windows |
bkhouri
reviewed
Apr 29, 2025
| @@ -500,7 +499,9 @@ let package = Package( | |||
| "PackageGraph", | |||
| ], | |||
| exclude: ["CMakeLists.txt", "README.md"], | |||
| swiftSettings: commonExperimentalFeatures | |||
| swiftSettings: commonExperimentalFeatures + [ | |||
| .unsafeFlags(["-static"]), | |||
There was a problem hiding this comment.
question: out of curiosity, why did we add the -static flag here if we this PR is renaming BuildSupport to NativeBuildSupport?
There was a problem hiding this comment.
All those targets are supposed to have it, it was accidentally missed from this one before.
There was a problem hiding this comment.
I'm not sure we need it any more when building with Swift 6.1.
This module is intended to contain code exclusive to the native build system, in order to help more clearly identify the delineation between the three build system backends, and identify layering violations and new higher-level abstractions that will need to be created to delegate to the appropriate backend (SourceKit support is one major example).
jakepetroules
force-pushed
the
eng/PR-rename-build-module
branch
from
6b2856a to
d9197cd
Compare
|
@swift-ci test |
|
@swift-ci test windows |
pmattos
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is intended to contain code exclusive to the native build system, in order to help more clearly identify the delineation between the three build system backends, and identify layering violations and new higher-level abstractions that will need to be created to delegate to the appropriate backend (SourceKit support is one major example).