[Commands] Migrate: Group manifest update errors per target #8677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If migrate fails to insert one or more features into the manifest for a target, let's produce a single error that lists all of the features, this makes the logging less noisy.
xedin
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci please test |
|
@swift-ci please test self hosted Linux |
|
@swift-ci please test self hosted |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
bkhouri
reviewed
May 16, 2025
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
dschaefer2
approved these changes
May 16, 2025
|
@swift-ci please test self hosted Windows platform |
6 similar comments
|
@swift-ci please test self hosted Windows platform |
|
@swift-ci please test self hosted Windows platform |
|
@swift-ci please test self hosted Windows platform |
|
@swift-ci please test self hosted Windows platform |
|
@swift-ci please test self hosted Windows platform |
|
@swift-ci please test self hosted Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If migrate fails to insert one or more features into the manifest for a target, let's produce a single error that lists all of the features, this makes the logging less noisy.
Modifications:
SwiftPackageCommandto request manifest to all of the features related to a target and produce a single error if that fails.Result:
If manifest has some non-standard ways of defining targets or settings that cannot be updated by
AddSettting, migration logging is going to be more organized and less noisy.