Widen swift-crypto version range #8680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
fabianfett
reviewed
May 16, 2025
| @@ -1065,7 +1065,7 @@ if ProcessInfo.processInfo.environment["SWIFTCI_USE_LOCAL_DEPS"] == nil { | |||
| // dependency version changes here with those projects. | |||
| .package(url: "https://github.com/apple/swift-argument-parser.git", .upToNextMinor(from: "1.4.0")), | |||
| .package(url: "https://github.com/swiftlang/swift-driver.git", branch: relatedDependenciesBranch), | |||
| .package(url: "https://github.com/apple/swift-crypto.git", .upToNextMinor(from: "3.0.0")), | |||
| .package(url: "https://github.com/apple/swift-crypto.git", "3.0.0" ..< "3.13.0"), | |||
There was a problem hiding this comment.
I’d go so far that this should be a from statement
There was a problem hiding this comment.
Yeah, IIRC this would exclude 3.13.1 for example
There was a problem hiding this comment.
Yes, I want to make the change as close to the original while also opening up to include the latest current release. As I said in the description, would upToNextMajor (of from:) be best here? I assumed there was a reason it's not that already 🤔
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.upToNextMinor(from: "3.0.0")on swift-crypto prevents updating of dependent packages that need swift-crypto >= 3.1.0.Motivation:
We need to depend on SwiftPM (for reasons laid out here) and the narrow version range on swift-crypto (which is at version 3.12.3) prevents us from updating to a newer version of PostgresNIO, which requires swift-crypto >= 3.9.0.
Modifications:
This opens the range to 3.0.0 ..< 3.13.0, although perhaps simply
upToNextMajorwould also be acceptable? It would certainly prevent future instances of this happening.Result:
Dependents are able to update to the latest swift-crypto.