Skip to content

Add FreeBSD platform again to SwiftBuild PIF builder #8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add FreeBSD platform again to SwiftBuild PIF builder #8686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/SwiftBuildSupport/PackagePIFBuilder+Helpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,6 +968,7 @@ extension ProjectModel.BuildSettings.Platform {
case .windows: .windows
case .wasi: .wasi
case .openbsd: .openbsd
case .freebsd: .freebsd
default: preconditionFailure("Unexpected platform: \(platform.name)")
Copy link
Contributor Author

@pmattos pmattos May 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I discussed this offline with @jakepetroules and will add proper error handling here.

No more hard preconditionFailures, as this could cause clients to crash.

}
}
Expand Down