Make sdkRootPath property of swift-sdk.json targetTriples object optional #8687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcprux
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
Would you mind adding tests that verify this change? Thanks! |
|
Changes like this 100% need to have accompanying documentation, otherwise anyone reading the SE is going to be extremely confused. |
marcprux
changed the title
Happy to document as needed, but I don't believe the optionality of
What's an SE? |
Added in afdaa3f. Happy to add more tests for this if you have suggestions. |
Swift Evolution |
|
@swift-ci test |
|
@swift-ci test windows |
MaxDesiatov
added
needs documentation
and removed
needs tests
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the "sdkRootPath" property of
swift-sdk.jsonoptional.Motivation:
The Android SDK bundle (swiftlang/swift#80788) does not include the Android NDK's sysroot in the bundle itself, but instead relies on it being installed locally. The install location will vary, and the user will be able to configure it with a command (modulo #8584) like:
However, since the
SwiftSDKMetadataV4.sdkRootPathproperty is declared as non-optional, some value must be included in theswift-sdk.jsonfile.@MaxDesiatov at swiftlang/swift#80788 (comment) mentions:
Modifications:
Change
SwiftSDKMetadataV4.sdkRootPathfromStringtoString?Result:
The swift-sdk.json can now contain destinations that do not specify a
sdkRootPathproperty.