Pass the correct toolchain path to SwiftBuild on Windows and FreeBSD #8737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakepetroules
requested review from
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024 and
daveyc123
as code owners
|
@swift-ci test |
Amendment to #8696 which computes the correct path on Windows and FreeBSD, which use different install layouts from the other platforms.
jakepetroules
force-pushed
the
eng/PR-tcpath
branch
from
5506c9e to
8d144a7
Compare
owenv
approved these changes
May 28, 2025
|
@swift-ci test |
|
@swift-ci test windows |
|
Turns out this also needs to be paired with swiftlang/swift-build#535 to fully resolve the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amendment to #8696 which computes the correct path on Windows and FreeBSD, which use different install layouts from the other platforms.