Support property accesses on ~Escapable types #1154
Closed
+156
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for having nonescapable types on the LHS of property accesses in the
#expect(...)
and#require(...)
macros. This includes some additional changes that could lead to supporting a nonescapable result type in#require(...)
, but that may need more lifetime support in the language.Motivation:
In the BinaryParsing library, I have a nonescapable
ParserSpan
type. In the tests, I need to write#expect(span.count == 0)
instead of the more fluent#expect(span.isEmpty)
.Modifications:
I've enabled lifetime annotations in the
Testing
and test targets, and then added overloads of__checkPropertyAccess
and__checkValue
that allow~Escapable
parameters.Checklist: