FreeBSD: Gate GNU-only API #1183
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FreeBSD builds are currently using the GlibC modulemap to import the C runtimes. FreeBSD does not have `gnu_get_libc_version` resulting in build failures.
etcwilde
requested review from
stmontgomery,
grynspan,
briancroom and
suzannaratcliff
as code owners
grynspan
approved these changes
Jun 27, 2025
grynspan
added
bug
|
@swift-ci test |
Yes, we should create a new module and module map for FreeBSD and call it something else, but since everything piggybacks on the Glibc module map, it was convenient to avoid re-writing the |
CodingCarpincho
approved these changes
Jun 27, 2025
| @@ -136,7 +136,7 @@ func spawnExecutable( | |||
| // standardized in POSIX.1-2024 (see https://pubs.opengroup.org/onlinepubs/9799919799/functions/posix_spawn_file_actions_adddup2.html | |||
| // and https://www.austingroupbugs.net/view.php?id=411). | |||
| _ = posix_spawn_file_actions_adddup2(fileActions, fd, fd) | |||
| #if canImport(Glibc) | |||
There was a problem hiding this comment.
Add !OpenBSD while you're add it? SwiftTesting also has a bunch of existing OpenBSD conditionals.
There was a problem hiding this comment.
I've attempted to support OpenBSD but it's entirely untested. It's unclear to me if it would have a module named Glibc (its stdlib is not GNU.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeBSD builds are currently using the GlibC modulemap to import the C runtimes. FreeBSD does not have
gnu_get_libc_versionresulting in build failures.The use of this API was introduced in #1147