Skip to content

[Build] Fix host system query for older CMake. #73001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

al45tair
Copy link
Contributor

DISTRIB_PRETTY_NAME is only supported on CMake 3.22 and later, but we only require CMake 3.19.6.

`DISTRIB_PRETTY_NAME` is only supported on CMake 3.22 and later, but
we only require CMake 3.19.6.
@al45tair al45tair requested a review from drodriguez April 12, 2024 09:03
@al45tair
Copy link
Contributor Author

@swift-ci Please smoke test

@al45tair
Copy link
Contributor Author

@futurejones I think this fixes the CMake issue introduced by #72049.

@al45tair al45tair requested a review from etcwilde April 12, 2024 09:17
@futurejones
Copy link
Contributor

@al45tair, that looks good.
Thanks.

Copy link
Contributor

@drodriguez drodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to avoid the problem for us. Thanks!

@drodriguez drodriguez merged commit 682db94 into swiftlang:main Apr 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants