Skip to content

[Tests] NFC: Update lifetime tests to avoid overloading on borrowing/… #77147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Oct 21, 2024

…consuming attributes

Overloading like that should not be allowed but that would have to be addressed separately,
meanwhile let's add a label to consuming init to make sure that the test no longer relies on the type-checker hacks.

…consuming attributes

Overloading like that should not be allowed but that would have to
be addressed separately, meanwhile let's add a label to `consuming`
init to make sure that the test no longer relies on the type-checker
hacks.
@xedin xedin requested a review from meg-gupta October 21, 2024 18:42
@xedin xedin requested a review from eeckstein as a code owner October 21, 2024 18:42
@xedin
Copy link
Contributor Author

xedin commented Oct 21, 2024

Related to #77001

@meg-gupta
Copy link
Contributor

Thanks! LGTM

@xedin
Copy link
Contributor Author

xedin commented Oct 21, 2024

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Oct 22, 2024

@swift-ci please smoke test Windows

@xedin
Copy link
Contributor Author

xedin commented Oct 22, 2024

@swift-ci please clean test Windows platform

@xedin
Copy link
Contributor Author

xedin commented Oct 22, 2024

@swift-ci please test Windows platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Oct 22, 2024

@swift-ci please test Windows platform

@xedin xedin merged commit 4a29db5 into swiftlang:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants