[NFC] Split DeclAttrOptions into two types #79966
Merged
+650
−320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We’re running out of bits in DeclAttrOptions, so split it in two: DeclAttrRequirements contains all the `On*` options that describe the declarations allowed to have the attribute, while the other options are now DeclAttrBehaviors. This commit also sorts the entries in DeclAttr.def by serialization code and improves the formatting of the file.
|
@swift-ci please smoke test |
beccadax
requested review from
QuietMisdreavus,
xymus,
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
tshortli
as code owners
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re running out of bits in DeclAttrOptions, so split it in two: DeclAttrRequirements contains all the
On*options that describe the declarations allowed to have the attribute, while the other options are now DeclAttrBehaviors.This commit also sorts the entries in DeclAttr.def by serialization code and improves the formatting of the file.
Extracted from #79466, where I need to steal more bits.