Skip to content

🍒 modulemap: Add missing dependency on vcruntime #82223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/6.2
Choose a base branch
from
Open

🍒 modulemap: Add missing dependency on vcruntime #82223

wants to merge 1 commit into from

Conversation

Steelskin
Copy link
Contributor

  • Explanation:
    stdlib.h includes limits.h, which is defined in the vcruntime module.
  • Scope:
    This fixes the module map usage with static linking on Windows.
  • Issues:
    N/A
  • Original PRs:
    modulemap: Add missing dependency on vcruntime #82126
  • Risk:
    Very low. CI should catch any issue.
  • Testing:
    Local build + CI.
  • Reviewers:
    @compnerd

@compnerd @Steelskin
🍒 modulemap: Add missing dependency on vcruntime
d0ca623 
`stdlib.h` includes `limits.h`, which is defined in the `vcruntime`
module.
@Steelskin Steelskin requested a review from a team as a code owner June 12, 2025 18:09
@compnerd
Copy link
Member

@swift-ci please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
swift 6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Steelskin @compnerd