feat: new "content" option to copy command #2447
Conversation
This change extends the copy command by introducing a new "content" option. When users use cg "content", the command reads the file's contents and copies them to the clipboard instead of just copying file paths or names.
|
Thank you for the PR, I have some questions:
|
When multiple files are selected, the command works as expected, copying the contents of all the files, with a new line between each file's content.
When copying a binary file or a file containing binary content, the copy command attempts to read the file as text using fs::read_to_string. If the content cannot be interpreted as text (e.g., for binary files), an error will be caught and logged.
In this case, the command will return an empty string (Cow::Borrowed(OsStr::new(""))) as a fallback to ensure the operation doesn't break.
When both a text file and a binary file are selected, the copy command will first read the text file and copy its content to the clipboard. For the binary file, it will return an empty string, as binary content cannot be copied as text. The text content will be copied to the clipboard, while the binary file will be effectively ignored (in terms of content). The error from the binary file read attempt will also be logged as shown earlier. I hope this helps clarify things! I'm open to any suggestions and appreciate all the feedback. Thanks for this great project ❤️ |
|
@sxyazi Just following up on this PR—let me know if there's anything that needs improvement! I'm not very familiar with the codebase, so if you have any suggestions or a preferred approach, I'd be happy to adjust the implementation. Thanks for your time! |
sxyazi
force-pushed
the
main
branch
2 times, most recently
from
75fad25 to
9565c1b
Compare
Added the content type handling in the copy command, allowing file content to be copied to the clipboard.