Skip to content

913309: In AdaptiveUI Grid, localization is not working correctly on filter dialog header text and filter icon title #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MUTHUSELVISF3942
Copy link
Collaborator

@MUTHUSELVISF3942 MUTHUSELVISF3942 commented Oct 8, 2024

Bug description

In the filter menu dialog, the Filter button is rendered to execute the filtering action. The text on this button can be localized using the FilterButton locale keyword. When applying localization to the FilterButton (using the locale keyword), the same localized text is displayed on both the Filter Icon's tooltip (title) and the Filter dialog header in the Adaptive UI. We need to provide an option to customize the Filter Icon's tooltip and the Filter dialog header text with separate locale keywords.

Root cause

In the Adaptive UI grid, both the Filter Icon's title and the Filter Dialog header text are derived from the same locale keyword (FilterButton), which is causing the issue.

Reason for not identifying earlier

Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.

  • Guidelines/documents are not followed

  • Common guidelines / Core team guideline

  • Specification document

  • Requirement document

  • Guidelines/documents are not given

  • Common guidelines / Core team guideline

  • Specification document

  • Requirement document

Reason:

Guidelines/documents are not given - Requirement document

Action taken:

Added the manual testing sample to ensure this issue in future. You can find the testbed sample in the below location.
https://github.com/essential-studio/ej2-grid-playwright-test/pull/602

Related areas:

Adaptive Grid, Sort, Filter, Localization

Is it a breaking issue?

No

Solution description

We have provided separate locale keywords for the filter icon, sort icon title, and filter dialog header text. Now, each element's text is localized using its specific keyword.

Output screenshots

Before

beforeadaptive

After

after

Areas affected and ensured

Responsive-dialog-renderer.ts file getHeaderTitle method
Toolbar.ts file render method
Grid.ts file initProperties method

Ensured the following cases:

  • Ensure the Sort and filter dialog adaptive grid
  • Ensure all localization name in sort and filter

Additional checklist

This may vary for different teams or products. Check with your scrum masters.

  • Did you run the automation against your fix? - Yes

  • Is there any API name change? - No

  • Is there any existing behavior change of other features due to this code change? - No

  • Does your new code introduce new warnings or binding errors? - No

  • Does your code pass all FxCop and StyleCop rules? a- No

  • Did you record this case in the unit test or UI test? - Yes

@MUTHUSELVISF3942 MUTHUSELVISF3942 changed the title 913309: Grid Menu Filter Adaptive UI: Filter Dialog Header Incorrectly Uses Filter Button Text 913309: In AdaptiveUI Grid, localization is not working correctly on filter dialog header text and filter icon title Oct 9, 2024
Copy link

@rajapandiyan-settu rajapandiyan-settu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the description, demo and the fix. Everything is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants