-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename template/extras/pnpm/.npmrc to _npmrc (remove "." prefix) to fix eslint installation error #2092
fix: rename template/extras/pnpm/.npmrc to _npmrc (remove "." prefix) to fix eslint installation error #2092
Conversation
🦋 Changeset detectedLatest commit: 0c2940d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pulled this and looks good to me - can confirm changes work correctly ❤️ fixes #2093 |
I was responsible for PR #2090. Locally it was working fine and I had no idea why the published version was having this problem. Thanks for figuring out the issue! ❤️ I would personally rename the .npmrc file in extras folder to npmrc or _npmrc and make the necesssary changes in the eslint.ts file instead of explicitly specifying it in the package.json. |
When will this be merged?, currently facing the same issue! |
… package.json inclusion
ya good call -- just made that change to the PR |
K lol actually just noticed that other templated files like gitignore use underscore prefixes so changed it to that to follow convention |
✅ Checklist
Changelog
After the PR #2090 was merged to fix a VSCode ESLint Plugin issue with pnpm@10, the pnpm/.npmrc file that it PR added (which it references in cli/src/installers/eslint.ts) isn't getting included in the package, likely because npm packaging typically doesn't include dotfiles unless explicitly specified in the package.json "files" array.
This is causing the
pnpn create t3-app@latest
installation to abort during the eslint boilerplating because that .npmrc file can't be found:This can be confirmed by the following command:
Fix: explicitly add the template/extras/pnpm/.npmrc file to the cli/package.json "files" array to ensure it gets included in the package
💯