Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty string from sed args when not on Darwin #2100

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

calthejuggler
Copy link

@calthejuggler calthejuggler commented Apr 5, 2025

Closes #2099 and #2088

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

The start database bash scripts now check if you are running a Darwin machine. If so, it uses the empty string arg for sed, but if not, it omits it.

I also updated the name of the mysql db to include mysql instead of postgres


Screenshots

BEFORE (postgres):
20250405_18h16m40s_grim

BEFORE (mysql):
20250405_18h18m18s_grim

AFTER (postgres):
20250405_18h20m29s_grim

AFTER (mysql):
20250405_18h21m43s_grim

💯

Copy link

changeset-bot bot commented Apr 5, 2025

🦋 Changeset detected

Latest commit: b44b92e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2025 5:22pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: start-database.sh password generation doesn't work on Arch Linux
1 participant