Feature/response models #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
describe_full_response_schemafunction to provide a more comprehensive JSON response schema. Specifically, it traces references until the entire top level response model is fully defined, and mirrors the output of pydanticsBaseModel.json_model_schemaoutput for a specific model.This can become large for complex models, but seems appropriate given the name of the option.
The major reason for this change is that the original code would discard
Unionfields that get translated toanyOf, which were removed in theclean_schema_for_displayfunction.This PR is WIP, and needs at least two unit tests: one for
Unionfields and one for fields defined by a pydanticBaseModel