Skip to content

feat(protocol): allow perconfers/proposers to mark blocks #19250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 16, 2025
Merged

feat(protocol): allow perconfers/proposers to mark blocks #19250

merged 11 commits into from
Apr 16, 2025

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 10, 2025 •
edited
Loading

When multiple blocks are preonfirmed by one preconfer, they can be marked differently using the new marker parameter.

@dantaik dantaik marked this pull request as ready for review April 10, 2025 13:45
@dantaik dantaik requested a review from smtmfft April 10, 2025 13:46
@dantaik dantaik changed the title feat(protocol): allow perconfers to mark blocks feat(protocol): allow perconfers/proposers to mark blocks Apr 12, 2025
@dantaik
Copy link
Contributor Author

dantaik commented Apr 14, 2025

@smtmfft please take a look.

smtmfft
smtmfft approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@smtmfft smtmfft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for proposer's own use?? or it's a public protocol value that is read/used by the others.

@dantaik
Copy link
Contributor Author

dantaik commented Apr 14, 2025

only for proposer's own use?? or it's a public protocol value that is read/used by the others.

This allows a preconfer to mark its preconf-ed blocks before the blocks are proposed, then when slashing is enabled, these values will be used to slash the preconfer if 1) the marker value is invalid, or 2) the block preconf-ed is different from the blocks proposed.

@dantaik dantaik changed the base branch from main to shasta_upgrade April 16, 2025 01:38
@dantaik dantaik enabled auto-merge April 16, 2025 01:38
@dantaik dantaik disabled auto-merge April 16, 2025 02:06
@dantaik dantaik merged commit 1be9779 into shasta_upgrade Apr 16, 2025
5 checks passed
@dantaik dantaik deleted the block_annotation branch April 16, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adaki2004 adaki2004 adaki2004 approved these changes

@smtmfft smtmfft smtmfft approved these changes

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@YoGhurt111 YoGhurt111 Awaiting requested review from YoGhurt111

Assignees
No one assigned
Labels
shasta Shasta Fork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @adaki2004 @smtmfft @davidtaikocha