fix(taiko-client): fix an occasional engine.SYNCING error when receiving P2P preconf blocks
#19262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iving P2P preconf blocks
packages/taiko-client/driver/chain_syncer/blob/blocks_inserter/common.go
Outdated
Show resolved
Hide resolved
…/common.go Co-authored-by: Copilot <[email protected]>
davidtaikocha
requested review from
YoGhurt111,
mask-pp,
cyberhorsey and
Copilot
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/taiko-client/driver/driver_test.go:688
- [nitpick] Consider using a consistent RPC interface reference (e.g., s.d.rpc) instead of a package-level rpc to improve code clarity.
s.Nil(rpc.SetHead(context.Background(), s.RPCClient.L2, l2Head1.Number))
packages/taiko-client/driver/driver_test.go:649
- The test uses randomness (e.g., for fork lengths and block shuffling) which may lead to nondeterministic behavior; consider setting a fixed random seed to ensure reproducibility.
func (s *DriverTestSuite) TestGossipMessagesRandomReorgs() {
davidtaikocha
commented
Apr 13, 2025
YoGhurt111
approved these changes
Apr 14, 2025
cyberhorsey
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some improvements for Ontake blocks
basefeecalculation in this PR, which is not necessary but a nice to have.