Skip to content

Dialog is not returning focus after updating to vue 3.5 #3686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jardakotesovec opened this issue Apr 10, 2025 · 0 comments · May be fixed by #3687
Open

Dialog is not returning focus after updating to vue 3.5 #3686

jardakotesovec opened this issue Apr 10, 2025 · 0 comments · May be fixed by #3687

Comments

@jardakotesovec
Copy link

jardakotesovec commented Apr 10, 2025

After recent update to vue 3.5, we encountered regression on setting focus after Dialog is closed, which is significant accessibility setback.

It seems that with vue 3.5 in some scenarios computed properties get calculated sooner than before, which makes it skip to restoration in unMounted hook.

Here is PR to address it #3687

What package within Headless UI are you using?

@headlessui/vue

What version of that package are you using?

v1.7.23

What browser are you using?

Chrome

Reproduction URL

Describe your issue

In the reproduction URL, you can reproduce it by clicking on Open Dialog 2, closing the Dialog. And when hitting <Tab> you can see its starting from Open Dialog 1, instead of Open Dialog 2 button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant