Improve language server detection for workspace folders #1334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/parallel-workspace-file-search
branch
from
034c2d2 to
3737a96
Compare
thecrypticace
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should enable quicker booting of the language server in large multi-root workspaces
Now we'll start the server as soon as any search has requested that it be started. Any remaining searches will be cancelled instead of waiting for them to complete. The language server itself will still do a more exhaustive search to find projects in all registered workspace folders.
@configTailwind CSS v4 required us to analyze the workspace for more stylesheets that may contain
@import(because@import "tailwindcss"and similar),@theme, etc… but these are only supported in.cssfiles and not.styl,.sass,.scss,.less, etc…We were already doing this because v3 looked for
@configbut that is valid in any stylesheet type. Now we restrict@import,@theme, etc matching to.cssfiles and we'll be less likely to start the server if we don't need to.