[PR-24286] Republish Talkable Android app #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doimhneacht
force-pushed
the
rosul-PR-24286
branch
from
07746d8 to
4fc268f
Compare
dgtv
reviewed
Apr 29, 2025
build.gradle
Outdated
| @@ -1,14 +1,18 @@ | |||
| // Top-level build file where you can add configuration options common to all sub-projects/modules. | |||
|
|
|||
| buildscript { | |||
| // Required for sdk version retrieval to work as of Android Studio 4.1.0: https://issuetracker.google.com/issues/158695880 | |||
| project.ext.set("sdk_version_code", 42) | |||
| project.ext.set("sdk_version_name", "0.5.13") | |||
There was a problem hiding this comment.
please instead move it to gradle.properties or root-level ext { … } outside buildscript. Here is more detailed explanation:
app/src/androidTest/java/com/talkable/demo/ApplicationTest.java
Outdated
Show resolved
Hide resolved
Doimhneacht
force-pushed
the
rosul-PR-24286
branch
from
4fc268f to
fa7ab2c
Compare
dgtv
approved these changes
May 2, 2025
dgtv
reviewed
May 5, 2025
| targetSdkVersion 31 | ||
| versionCode 34 | ||
| versionName "0.5.3" | ||
| applicationId "com.talkable.demoapp" |
There was a problem hiding this comment.
please change it to appdemo as I had to create a new release and used this name
Suggested change
| applicationId "com.talkable.demoapp" | |
| applicationId "com.talkable.appdemo" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Stories