enh: dnode condition pushdown #30596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetosea
requested review from
guanshengliang,
hzcheng and
dapan1121
as code owners
facetosea
force-pushed
the
fix/TS-6244/showDnodes
branch
from
6c36138 to
503dbcd
Compare
dapan1121
reviewed
Apr 5, 2025
| if (pOperNode->opType == OP_TYPE_EQUAL || pOperNode->opType == OP_TYPE_NOT_EQUAL) { | ||
| SNode* pLeft = pOperNode->pLeft; | ||
| SNode* pRight = pOperNode->pRight; | ||
| if ((QUERY_NODE_COLUMN == nodeType(pLeft) && strcmp(((SColumnNode*)pLeft)->node.aliasName, "dnode_id") == 0) || |
There was a problem hiding this comment.
这个条件严重不足，不能因为有一列叫"dnode_id"就可以做这个优化，用户的表里有个列叫"dnode_id"也可以吗
| OPTIMIZE_FLAG_TEST_MASK(pScan->node.optimizedFlag, OPTIMIZE_FLAG_PUSH_DOWN_CONDE) || | ||
| TSDB_SYSTEM_TABLE == pScan->tableType) { | ||
| OPTIMIZE_FLAG_TEST_MASK(pScan->node.optimizedFlag, OPTIMIZE_FLAG_PUSH_DOWN_CONDE) | ||
| // || TSDB_SYSTEM_TABLE == pScan->tableType |
| @@ -5021,8 +5021,9 @@ int32_t tSerializeSDnodeListRsp(void *buf, int32_t bufLen, SDnodeListRsp *pRsp) | |||
| int32_t num = taosArrayGetSize(pRsp->dnodeList); | |||
| TAOS_CHECK_EXIT(tEncodeI32(&encoder, num)); | |||
| for (int32_t i = 0; i < num; ++i) { | |||
| SEpSet *pEpSet = taosArrayGet(pRsp->dnodeList, i); | |||
| TAOS_CHECK_EXIT(tEncodeSEpSet(&encoder, pEpSet)); | |||
| SDNodeAddr *pAddr = taosArrayGet(pRsp->dnodeList, i); | |||
There was a problem hiding this comment.
这改变了消息怎么保证兼容性？怎么能向main提交？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.