Rubyとbundlerのバージョンを更新 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.6でのbundlerのデフォルトバージョンを忘れていたのですが、TravisCIで2.6.6を一応動かして通ったので動作保証バージョンは2.6と書いてもいいかもしれない？ でも2.7もリリースされてから既に半年経っているので、個人的にはREADMEには動作保証は2.7と書いてしまいたいと思いました。 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
現在の最新stableバージョンである2.7で動作確認を行ったのでREADMEを修正しました。
また、放置されてしまっている #16 と同様にrspec実行時のpower-assertのログをサンプルとしてREADMEに記載するようにしました。
Gemfile.lockのbundlerが1系のままになっており、そのままではruby 2.7では
bundle installもできなかったのでbundle update --bundlerで2系に更新しておきました。