Skip to content

Drop support for Python 3.8 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.

Addresses #\< fill in issue number here >
Addresses #< fill in issue number here >

## Types of changes

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
uses: tektronix/python-package-ci-cd/.github/workflows/[email protected]
with:
package-name: tm_devices
python-versions-array: '["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
python-versions-array: '["3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
operating-systems-array: '["ubuntu", "windows", "macos"]'
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
commit-user-email: ${{ vars.TEK_OPENSOURCE_EMAIL }}
release-level: ${{ inputs.release-level }}
build-and-publish-python-package: true
python-versions-array: '["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
python-versions-array: '["3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
operating-systems-array: '["ubuntu", "windows", "macos"]'
previous-changelog-filepath: python_semantic_release_templates/.previous_changelog_for_template.md
previous-release-notes-filepath: python_semantic_release_templates/.previous_release_notes_for_template.md
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
with:
repo-name: tektronix/tm_devices
operating-systems-array: '["ubuntu", "windows", "macos"]'
python-versions-array: '["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
python-versions-array: '["3.9", "3.10", "3.11", "3.12", "3.13"]' # when updating this, make sure to update all workflows that use this strategy
upload-to-codecov: true
enable-retry-os-array: '["macos"]'
secrets:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
update-pre-commit: true
run-pre-commit: true
pre-commit-hook-skip-list: pylint,pyright,pyright-verifytypes,pyroma,poetry-audit
pre-commit-repo-update-skip-list: https://github.com/executablebooks/mdformat,https://github.com/pappasam/toml-sort,https://github.com/python-jsonschema/check-jsonschema
pre-commit-repo-update-skip-list: ''
export-dependency-groups: docs,tests
permissions:
contents: write
Expand Down
17 changes: 8 additions & 9 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ repos:
- id: remove-tabs
- id: forbid-tabs
- repo: https://github.com/python-jsonschema/check-jsonschema
rev: cb3c2be894b151dff143b1baf6acbd55f2b7faed # frozen: 0.30.0
rev: 06e4cc849d03f3a59ca223a4046f4bb5bb2aba6d # frozen: 0.33.0
hooks:
- id: check-readthedocs
- id: check-dependabot
Expand All @@ -65,7 +65,7 @@ repos:
hooks:
- id: curlylint
- repo: https://github.com/executablebooks/mdformat
rev: 08fba30538869a440b5059de90af03e3502e35fb # frozen: 0.7.17
rev: ff29be1a1ba8029d9375882aa2c812b62112a593 # frozen: 0.7.22
hooks:
- id: mdformat
args: [--number, --end-of-line, keep, --ignore-missing-references]
Expand All @@ -91,7 +91,7 @@ repos:
hooks:
- id: check-poetry
- repo: https://github.com/pappasam/toml-sort
rev: b9b6210da457c38122995e434b314f4c4a4a923e # frozen: v0.23.1
rev: 4ec24891e200ae663aa2a7cecd19516080777133 # frozen: v0.24.2
hooks:
- id: toml-sort-fix
- repo: local
Expand Down Expand Up @@ -139,9 +139,8 @@ repos:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
- id: ruff-format
# TODO: Re-enable this once https://github.com/PyCQA/docformatter/issues/293 is resolved
# - repo: https://github.com/PyCQA/docformatter
# rev: dfefe062799848234b4cd60b04aa633c0608025e # frozen: v1.7.5
# hooks:
# - id: docformatter
# additional_dependencies: [tomli]
- repo: https://github.com/PyCQA/docformatter
rev: 4cf1ea547d79f6e15ce51eae0eb5f986053ab65c # frozen: v1.7.6
hooks:
- id: docformatter
additional_dependencies: [tomli]
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ Valid subsections within a version are:

Things to be included in the next release go here.

### Removed

- Python 3.8 support has been removed from the package. The minimum supported version is now Python 3.9.

---

## v3.2.0 (2025-05-07)
Expand Down Expand Up @@ -50,7 +54,7 @@ Things to be included in the next release go here.

### Merged Pull Requests

- Set offset after impedance so that it is properly adjusted ([#411](https://github.com/tektronix/tm_devices/pull/411))
- Set offset after impedance so that it is properly adjusted ([#411](https://github.com/tektronix/tm_devices/pull/411))

### Fixed

Expand Down Expand Up @@ -688,7 +692,7 @@ However, please read through all changes to be aware of what may potentially imp
### Merged Pull Requests

- fix: Removed unused command files. ([#143](https://github.com/tektronix/tm_devices/issues/143))
- fix: modified API under MSO 2,4,5,6 modules ([#142](https://github.com/tektronix/tm_devices/issues/142))
- fix: modified API under MSO 2,4,5,6 modules ([#142](https://github.com/tektronix/tm_devices/issues/142))
- Update PI Device close method to catch VisaIOErrors ([#141](https://github.com/tektronix/tm_devices/issues/141))
- ci: Update pre-commit hooks and linter versions. ([#139](https://github.com/tektronix/tm_devices/issues/139))
- gh-actions(deps): Bump the gh-actions-dependencies group with 1 update ([#123](https://github.com/tektronix/tm_devices/issues/123))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
{# TODO: Drop Python 3.8: remove this file after updating to newer versions of mkdocstrings-python #}
{% extends "_base/class.html.jinja" %}
{% block inheritance_diagram %}
{#- Inheritance diagram block.
Expand Down
2 changes: 1 addition & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ devices:
- Different products may support ranges outside the commonly used rates
listed here.
- `data_bits:` The number of data bits in each character.
- One of \[5, 6, 7, 8\].
- One of [5, 6, 7, 8].
- `flow_control:` Control for pausing/resuming data stream between slower
devices.
- Valid options: `none`, `xon_xoff`, `dtr_dsr`, or `rts_cts`
Expand Down
2 changes: 1 addition & 1 deletion docs/glossary.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ DMM
: Digital Multimeter

DPOJET
: A jitter, noise, timing, and eye diagram analysis tool for Tektronix Performance Digital Oscilloscopes
: A jitter, noise, timing, and eye diagram analysis tool for Tektronix Performance Digital Oscilloscopes

GPIB
: General Purpose Interface Bus
Expand Down
3 changes: 2 additions & 1 deletion docs/macros.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@
import pathlib
import re

from collections.abc import Generator
from importlib import import_module
from typing import Any, Generator, Optional, Set, Tuple
from typing import Any, Optional, Set, Tuple

import tomli

Expand Down
Loading
Loading