Skip to content

Including Lazy, Commands, Internal and Static Attributes in payload to IoT Agent Manager #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES_NEXT_RELEASE
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Update codebase to use ES6
- Fix or disable eslint errors
Add prettier code formatting
Add husky and lint-staged
Fix: Add support for lazy and internal_attributes in service notifications to Manager (#768)
Fix: combine multi-entity and expressions with duplicate attribute name, by enabling expression over object_id (which are not duplicated in a attribute mapping contrary to name) (#941)
Fix: bug in legacy and JEXL expression that was not converting "0" to 0
Fix: support for mapping different attributes to the same entity_name
Fix: support for mapping different attributes to the same entity_name
2 changes: 2 additions & 0 deletions lib/services/common/iotManagerService.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ function register(callback) {
service_path: service.subservice,
attributes: service.attributes,
static_attributes: service.staticAttributes,
internal_attributes: service.internalAttributes,
lazy: service.lazy,
commands: service.commands,
description: service.description,
timezone: service.timezone,
Expand Down
13 changes: 12 additions & 1 deletion test/unit/examples/iotamRequests/registrationWithGroups.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,18 @@
"type": "Boolean"
}
],
"commands":[{"name":"wheel1","type":"Wheel"}]
"lazy": [
{
"name": "luminescence",
"type": "Lumens"
}
],
"commands":[
{
"name": "wheel1",
"type": "Wheel"
}
]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,18 @@
"type": "Boolean"
}
],
"commands":[{"name":"wheel1","type":"Wheel"}]
"commands": [
{
"name": "wheel1",
"type": "Wheel"
}
],
"lazy": [
{
"name": "luminescence",
"type": "Lumens"
}
]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@
"values": "123,12"
}
],
"commands":[{"name":"wheel1","type":"Wheel"}]
"commands": [
{
"name": "wheel1",
"type": "Wheel"
}
]
}
]
}