Skip to content

REMOVE unneeded file #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2020
Merged

REMOVE unneeded file #948

merged 2 commits into from
Nov 27, 2020

Conversation

fgalan
Copy link
Member

@fgalan fgalan commented Nov 26, 2020

It seems this file was re-introduced by PR #849.

As far as I understand the file is no longer in use (as we changed from jshint to eslint recently) and should be removed, isn't it @jason-fox ?

@jason-fox
Copy link
Contributor

Yes, remove it.

@fgalan fgalan requested a review from AlvaroVega November 27, 2020 13:10
Copy link
Member

@AlvaroVega AlvaroVega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega merged commit 1573d12 into master Nov 27, 2020
@AlvaroVega AlvaroVega deleted the hardening/remove-unneeded-file branch November 27, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants