Skip to content

fix: Get rid of istanbul-instrumenter-loader #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

mjameswh
Copy link
Contributor

What changed

In @temporalio/nyc-test-coverage:

  • Remove dependency on istanbul-instrumenter-loader
  • Replaced by a private webpack module loader
  • Add integration tests
  • Modify rules to make sure that all user source files are included in coveerage

Why

@mjameswh mjameswh merged commit d62a2c3 into temporalio:main Dec 16, 2022
@mjameswh mjameswh deleted the istanbul-loader branch December 16, 2022 22:39
Copy link
Contributor

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just from reading. I've been having some trouble running this locally, but I get the same issues when running without this change. Will keep trying.

Copy link
Contributor

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed to get this working locally successfully. Turns out the issue that I was experiencing only happened when I tried to install a patched version of nyc-test-coverage with npm pack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants