fix: Do not expose output from build command in Docker #677
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @antonbabenko, I'd be extremely grateful if you could find time to review this. It's a one-liner 😄 |
antonbabenko
approved these changes
May 16, 2025
| @@ -49,7 +49,7 @@ data "external" "archive_prepare" { | |||
| resource "local_file" "archive_plan" { | |||
| count = var.create && var.create_package ? 1 : 0 | |||
|
|
|||
| content = data.external.archive_prepare[0].result.build_plan | |||
| content = var.build_in_docker ? sensitive(data.external.archive_prepare[0].result.build_plan) : data.external.archive_prepare[0].result.build_plan | |||
There was a problem hiding this comment.
The best solution would be to hide values ONLY if there are secrets inside. Function issensitive became available in Terraform 1.8 but this module expects Terraform 1.0.
There was a problem hiding this comment.
Indeed, my first patch was using the issensitive function, but then I checked it only appeared in 1.8. Thank you @antonbabenko!
antonbabenko
approved these changes
May 16, 2025
antonbabenko
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
May 16, 2025
## [7.20.3](v7.20.2...v7.20.3) (2025-05-16) ### Bug Fixes * Do not expose output from build command in Docker ([#677](#677)) ([75ee97d](75ee97d))
|
This PR is included in version 7.20.3 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If dependencies build is performed using Docker, and additional Docker options are specified, and any of those options contain a sensitive value, the content of the archive file has also to be marked as sensitive, to avoid exposing these sensitive options in the Terraform plan. Unfortunately the
externalprovider doesn't support marking output values as sensitive, so this workaround seems like an only viable solution.Motivation and Context
Fixes #676.
Breaking Changes
None.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request