-
Notifications
You must be signed in to change notification settings - Fork 33
feat: set svelte context in render fn #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please merge this. I need this. What is the roadblock? |
Please merge |
What is the problem with this PR? |
As far as I know, there is no problem. This library just does not seem to be actively maintained. I previously asked for a review in the Discord channel, but got no answer there either. |
Okay, can someone from the maintainers add (@apricote or @yanick), so we can proceed? @benmccann Referencing #182 as well, because it has some tests in it. |
For what it's worth, if we want to go with this PR, I'm totally game to rebase my tests on it. |
Nah, your PR is the same, but with tests included. Your PR should be favored. This one should be closed. Also this one here is out of date. |
Closing in favor of #182 that also includes test for the functionality. |
Thank you :) |
Fixes #118
Fixes #136
Description
Support passing the svelte component context in
componentOptions
.Previously one had to write a wrapper component that could set the context.
Usage