Skip to content

Nk assets creation #6922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Nk assets creation #6922

wants to merge 2 commits into from

Conversation

pinkhoodie
Copy link
Contributor

@pinkhoodie pinkhoodie commented May 2, 2025


PR-Codex overview

This PR introduces new components and pages for managing digital assets, including tokens and NFTs. It enhances the dashboard with asset creation functionalities, UI improvements, and structure for handling token and NFT collections.

Detailed summary

  • Added Layout component for asset management.
  • Introduced AssetsPage for viewing and creating tokens and NFTs.
  • Updated ProjectSidebarLayout to include links for asset management.
  • Created CreateTokenPage and CreateNFTPage for token and NFT creation processes.
  • Implemented forms with validation for token and NFT details.
  • Added step indicators for user navigation in creation processes.
  • Included charts and tables for displaying asset data.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 2, 2025

⚠️ No Changeset found

Latest commit: 75c6d7f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:32am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:32am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:32am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:32am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 1:32am

Copy link
Contributor

graphite-app bot commented May 2, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 50.93 KB (0%) 1.1 s (0%) 302 ms (+157.61% 🔺) 1.4 s
thirdweb (cjs) 143.05 KB (0%) 2.9 s (0%) 488 ms (+84.9% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 122 ms (+1660.06% 🔺) 236 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 50 ms (+1248.5% 🔺) 60 ms
thirdweb/react (minimal + tree-shaking) 19.47 KB (0%) 390 ms (0%) 128 ms (+523.25% 🔺) 518 ms

Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.10%. Comparing base (818189e) to head (75c6d7f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6922      +/-   ##
==========================================
- Coverage   55.21%   55.10%   -0.12%     
==========================================
  Files         896      896              
  Lines       57057    57193     +136     
  Branches     3955     3956       +1     
==========================================
+ Hits        31506    31514       +8     
- Misses      25454    25582     +128     
  Partials       97       97              
Flag Coverage Δ
packages 55.10% <ø> (-0.12%) ⬇️

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant